Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix first-class callables with built-in, magic, undefined methods and callable expressions #7232

Merged
merged 2 commits into from Dec 30, 2021

Conversation

trowski
Copy link
Contributor

@trowski trowski commented Dec 27, 2021

This addresses issues discovered when attempting to use first-class callables with built-in class methods, undefined methods, magic methods, and as a the callable expression to functions such as array_map.

Closes #7196.

@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Dec 27, 2021
@trowski
Copy link
Contributor Author

trowski commented Dec 27, 2021

Hold off for now on merging, I think I found another case that wasn't covered.

@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

Sure. Mark it ready for review when you're done.

@weirdan weirdan marked this pull request as draft December 27, 2021 21:19
@trowski trowski marked this pull request as ready for review December 27, 2021 22:17
@weirdan weirdan merged commit 03b7e94 into vimeo:master Dec 30, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 30, 2021

Thanks!

@trowski trowski deleted the issue-7196 branch April 4, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First-class callable
3 participants