Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contextual inference for closure param types #7228

Merged
merged 2 commits into from Dec 27, 2021
Merged

Contextual inference for closure param types #7228

merged 2 commits into from Dec 27, 2021

Conversation

klimick
Copy link
Contributor

@klimick klimick commented Dec 27, 2021 •
edited by weirdan

Closes #7209

Also solves my problem from #4535
Partially addresses #5820

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 27, 2021
@klimick
Copy link
Contributor Author

klimick commented Dec 27, 2021

Appearing UnnecessaryVarAnnotation in the psl is reasonably. What should I do in this case?

@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

I'll baseline that error once this PR is merged.

weirdan
weirdan approved these changes Dec 27, 2021
View reviewed changes
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@weirdan weirdan requested a review from orklah December 27, 2021 17:31
@orklah
Copy link
Collaborator

orklah commented Dec 27, 2021

Thanks!

@weirdan weirdan closed this Dec 27, 2021
@weirdan weirdan reopened this Dec 27, 2021
@weirdan weirdan merged commit 33466d8 into vimeo:master Dec 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

@orklah orklah orklah approved these changes

Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contextual inference for Closure param types
3 participants
@klimick @weirdan @orklah