Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle literal equality with integer ranges #7224

Merged
merged 1 commit into from Dec 26, 2021
Merged

handle literal equality with integer ranges #7224

merged 1 commit into from Dec 26, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Dec 26, 2021 •
edited by weirdan

This will fix a case with literal equality when integer ranges are involved, fixing #7223

Fixes #7223

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 26, 2021
@orklah orklah merged commit 52ab139 into vimeo:master Dec 26, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 26, 2021

Original snippet still fails though

@weirdan
Copy link
Collaborator

weirdan commented Dec 26, 2021

This fixed DocblockTypeContradiction, but not the RedundantCondition in the else branch of the ternary.

@orklah
Copy link
Collaborator Author

orklah commented Dec 26, 2021

Oh, good catch. I'll check that

@orklah orklah mentioned this pull request Dec 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Docblock-defined type 0|int<1, 16> for $length is never int(1)
2 participants
@orklah @weirdan