Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @psalm-internal with trailing whitespaces #7207

Merged

Conversation

sj-i
Copy link
Contributor

@sj-i sj-i commented Dec 23, 2021

This should work.
https://psalm.dev/r/e9cc52c5ef

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/e9cc52c5ef
<?php
namespace A\B {
    class Foo {
        /** @psalm-internal A\B */
        public static function barBar(): void {
            self::barBar();
        }
    }
}
Psalm output (using commit da802a5):

ERROR: InternalMethod - 6:13 - The method A\B\Foo::barBar is internal to A\B  but called from A\B\Foo

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 23, 2021
@weirdan weirdan force-pushed the fix-psalm-internal-with-trailing-whitespace branch 2 times, most recently from 7b7a542 to 1c07813 Compare December 27, 2021 05:30
@weirdan weirdan merged commit fa2877b into vimeo:master Dec 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants