Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add early file filtering to FileProvider::getFilesInDir() #7201

Merged
merged 3 commits into from Dec 23, 2021

Conversation

dvz
Copy link
Contributor

@dvz dvz commented Dec 22, 2021

Partially resolves .#7057

Extends the use of callable $directory_filter added via #7161 to additionally cover individual files, containing the project/extra/ignored check logic within FileProvider::getFilesInDir().

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 22, 2021
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but we need to fix the CI issue before we can proceed with this.

@orklah
Copy link
Collaborator

orklah commented Dec 23, 2021

Thanks!

@orklah orklah merged commit 79a9750 into vimeo:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants