Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closure param type inference in generic context #7200

Merged
merged 4 commits into from Dec 27, 2021
Merged

Fix closure param type inference in generic context #7200

merged 4 commits into from Dec 27, 2021

Conversation

klimick
Copy link
Contributor

@klimick klimick commented Dec 22, 2021

Fix #7199

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 22, 2021
@klimick
Copy link
Contributor Author

klimick commented Dec 22, 2021

Tests are passed locally. Maybe workflow workers are temporarily dead?

@orklah
Copy link
Collaborator

orklah commented Dec 22, 2021

yeah, there's something weird

@klimick klimick changed the title Fix closure param type inference generic context Fix closure param type inference in generic context Dec 22, 2021
@orklah
Copy link
Collaborator

orklah commented Dec 23, 2021

Can you rebase? CI should be ok now

@klimick
Copy link
Contributor Author

klimick commented Dec 23, 2021

Done

@weirdan
Copy link
Collaborator

weirdan commented Dec 26, 2021

Apparently, the rebase went wrong, so I have redone it.

@weirdan weirdan merged commit 66b5d60 into vimeo:master Dec 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 27, 2021

Thanks!

klimick added a commit to klimick/psalm that referenced this pull request Aug 15, 2023
klimick added a commit to klimick/psalm that referenced this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Closure parameters type inference broken in generic context
3 participants