New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use import instead of fully qualified namespaces #7060
Conversation
Mind looking into phar issue? See Lines 44 to 49 in e1d1ef3
|
Hmm, we probably should include this in the local tests |
ba52f88
to
2d199d1
Compare
@weirdan Fixed. But that was mor an educated guess than knowledge. Do you know what happened there? Doesn’t look wrong to me. Some magic with box that does some search-replace with |
Likely. Should we also revert other similar changes, e.g. in |
Yes, to be on the save side. The same code is in LanguageServer, Psalter, and Refactor. I guess when it breaks in Psalm it should do so there, too. |
4d5f100
to
81c94f1
Compare
1d2b149
to
9902898
Compare
Thanks! |
At least for most cases. Partials left for another PR as they need some more thinking.
All conversions were done carefullly, no tests fail. I hope that no external stuff (Plugins) break.
I don’t know now to review such a monster PR :-(
Fixes #7037