Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove always-false args #7056

Merged
merged 1 commit into from Dec 4, 2021
Merged

Remove always-false args #7056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 7 additions & 19 deletions src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php
View file
Open in desktop
Expand Up @@ -165,7 +165,6 @@ public static function scrapeAssertions(
$this_class_name,
$source,
$codebase,
false, //should this be $inside_negation??
$cache,
$inside_conditional
);
Expand All @@ -179,7 +178,6 @@ public static function scrapeAssertions(
$this_class_name,
$source,
$codebase,
false, //should this be $inside_negation??
$cache,
$inside_conditional
);
Expand Down Expand Up @@ -324,7 +322,6 @@ private static function scrapeEqualityAssertions(
?string $this_class_name,
FileSource $source,
?Codebase $codebase = null,
bool $inside_negation = false,
bool $cache = true,
bool $inside_conditional = true
): array {
Expand All @@ -348,7 +345,6 @@ private static function scrapeEqualityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
$cache,
$true_position
);
Expand All @@ -362,7 +358,6 @@ private static function scrapeEqualityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
$cache,
$inside_conditional,
$false_position
Expand Down Expand Up @@ -562,7 +557,6 @@ private static function scrapeInequalityAssertions(
?string $this_class_name,
FileSource $source,
?Codebase $codebase = null,
bool $inside_negation = false,
bool $cache = true,
bool $inside_conditional = true
): array {
Expand All @@ -588,7 +582,6 @@ private static function scrapeInequalityAssertions(
$source,
$inside_conditional,
$codebase,
$inside_negation,
$false_position
);
}
Expand All @@ -602,7 +595,6 @@ private static function scrapeInequalityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
$cache,
$inside_conditional
);
Expand Down Expand Up @@ -2074,7 +2066,6 @@ private static function getFalseInequalityAssertions(
FileSource $source,
bool $inside_conditional,
?Codebase $codebase,
bool $inside_negation,
int $false_position
): array {
$if_types = [];
Expand Down Expand Up @@ -2114,7 +2105,7 @@ private static function getFalseInequalityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
false,
$cache,
$inside_conditional
);
Expand Down Expand Up @@ -2192,7 +2183,6 @@ private static function getTrueInequalityAssertions(
?string $this_class_name,
FileSource $source,
?Codebase $codebase,
bool $inside_negation,
bool $cache,
bool $inside_conditional
): array {
Expand All @@ -2212,7 +2202,7 @@ private static function getTrueInequalityAssertions(
$this_class_name,
$source,
$codebase,
!$inside_negation
true
);
} else {
$var_name = ExpressionIdentifier::getArrayVarId(
Expand Down Expand Up @@ -2242,7 +2232,7 @@ private static function getTrueInequalityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
false,
$cache,
$inside_conditional
);
Expand Down Expand Up @@ -2770,7 +2760,6 @@ private static function getTrueEqualityAssertions(
?string $this_class_name,
FileSource $source,
?Codebase $codebase,
bool $inside_negation,
bool $cache,
int $true_position
): array {
Expand All @@ -2790,7 +2779,7 @@ private static function getTrueEqualityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation
false
);
} else {
$var_name = ExpressionIdentifier::getArrayVarId(
Expand Down Expand Up @@ -2820,7 +2809,7 @@ private static function getTrueEqualityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
false,
$cache
);

Expand Down Expand Up @@ -2895,7 +2884,6 @@ private static function getFalseEqualityAssertions(
?string $this_class_name,
FileSource $source,
?Codebase $codebase,
bool $inside_negation,
bool $cache,
bool $inside_conditional,
int $false_position
Expand All @@ -2916,7 +2904,7 @@ private static function getFalseEqualityAssertions(
$this_class_name,
$source,
$codebase,
!$inside_negation
true
);
} else {
$var_name = ExpressionIdentifier::getArrayVarId(
Expand Down Expand Up @@ -2946,7 +2934,7 @@ private static function getFalseEqualityAssertions(
$this_class_name,
$source,
$codebase,
$inside_negation,
false,
$cache,
$inside_conditional
);
Expand Down