New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't output console links in CI env #7049
Conversation
They are all but useless there, and are actually causing issue with GHA output. Fixes vimeo#7047
Test failure is legit, but not being able to rely on superglobals makes it quite a bit harder. |
This has to happen before third-party autoloader has a chance to mess up global environment.
Thanks for fixing the issue ! Question: Could we consider using https://packagist.org/packages/ondram/ci-detector for checking if it is running in CI ? |
Yeah, we could consider it if needed. Do you happen to use an exotic CI environment? |
On my side no, I only use Github and Gitlab. |
That said, that package support quite a large amount of CI system that I was not even aware of, check their README file ! |
That was kinda my point, if we weren't aware they existed, it will be the case for most people too :) If we have a feedback from a user, we'll consider making the change, but I try not to add dependencies for things I'm not sure are needed |
They are all but useless there, and are actually causing an issue with GHA output.
Fixes #7047