New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when baseline file is empty #7036

Merged

weirdan merged 1 commit into vimeo:master from kamil-tekiela:Add-exception

Dec 1, 2021

Contributor

kamil-tekiela commented Dec 1, 2021

This should solve the error:

Uncaught ValueError: DOMDocument::loadXML(): Argument #1 ($source) must not be empty in ...\vimeo\psalm\src\Psalm\ErrorBaseline.php:85


          Throw exception when baseline file is empty

5d99109

weirdan added the release:fix label

weirdan merged commit 7e7b595 into vimeo:master

Collaborator

weirdan commented Dec 1, 2021

Thanks!

Side note: we should probably annotate $source as non-empty-string so that Psalm would be able to catch it too.

weirdan mentioned this pull request

DOMDocument::loadXML() should reject empty strings #7039

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment