Infer ::from() and ::tryFrom() return types on backed enums
#7011
Conversation
weirdan
added
the
release:feature
weirdan
force-pushed
the
backed-enum-from
branch
from
76bee7d
to
806db28
Compare
| foreach ($original_class_storage->enum_cases as $case_name => $case_storage) { | ||
| if (UnionTypeComparator::isContainedBy( | ||
| $source_analyzer->getCodebase(), | ||
| \is_int($case_storage->value) ? |
There was a problem hiding this comment.
Is it possible to use a constant to initialize a case? If it happens, is_int() will fail. Can't we access the type at this moment?
There was a problem hiding this comment.
It's possible, and it fails. But not here.
https://3v4l.org/WHXIV#v8.1rc3
https://psalm.dev/r/3547ca91d3
There was a problem hiding this comment.
Built-in constants work.
User-defined constants don't: https://3v4l.org/nhGRA#v8.1rc3
Class constants work if the class is defined before the enum: https://3v4l.org/bcYPN#v8.1rc3.
Class constants from autoloaded classes do not work: https://3v4l.org/AjOCi#v8.1rc3
3v4l doesn't have proper 8.1 yet, so it's based on RC3. Some of the above could have been fixed before final release.
There was a problem hiding this comment.
Some of the above could have been fixed before final release.
I've just built 8.1 branch, and there are no changes for those cases.
Fixes #6429