fix signature for openssl_open under PHP >= 8.0

[pilif]

fixes the false InvalidArgument here: https://psalm.dev/r/d84f1672b7

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/d84f1672b7

<?php

$k = openssl_pkey_get_private('some file', 'very secret');
openssl_open("flupp", $decoded, "foobar", $k, "RC4");

Psalm output (using commit 55b2b6b):

ERROR: InvalidArgument - 4:43 - Argument 4 of openssl_open expects array<array-key, mixed>|resource|string, OpenSSLAsymmetricKey|false provided

[pilif]

I have force-pushed a new commit which fixes all openssl_* signatures for PHP >= 8.0.

In the end, I went with the long signature for that array keys argument: Even if some of the arguments as they are allowed now make no sense, they are allowed by PHP and we should not complain about valid PHP code, no matter how nonsensical.

One thing: there is openssl_pkey_get_details which returns an associative array whose members depend on the key passed in as the argument and none of the types of these key-dependent values are documented in the manual.

The existing return type was declared as array|false and this PR leaves it at that. If somebody wants to go through all of the combinations and figure out their types, that's a substantial additional task which I think should be subject to a future PR as with this PR, at least all openssl_* functions are useable with psalm under PHP8, where prior to this PR they weren't.

[pilif]

also - wow - what a minefield the openssl_* functions are.

stuff like

or

in functions related to crypto...

[weirdan]

There's a number of nullability nitpicks, but otherwise this looks really good.

[pilif]

thank you very much for your additional remarks. When I went through the functions, I mostly looked at the resource-typed parameters and didn't bother re-checking all the nullabilities. Now everything is up to date with the manual.

The windows tests fail before they even start testing with some missing infrastructure to install PHP. I don't know what's going on there, but I don't think it's related to the updated call map.

[weirdan]

I don't know what's going on there

Seems to be a temporary glitch. I've restarted the job and it seems to be working now.

[weirdan]

Thanks!