Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub fixes for mysqli extension #6986

Merged
merged 2 commits into from Nov 24, 2021
Merged

Conversation

kamil-tekiela
Copy link
Contributor

No description provided.

dictionaries/CallMap.php Show resolved Hide resolved
dictionaries/CallMap.php Show resolved Hide resolved
dictionaries/CallMap.php Show resolved Hide resolved
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 24, 2021
@kamil-tekiela kamil-tekiela force-pushed the mysqli-stub-fixes branch 2 times, most recently from b356a6f to fe7313c Compare November 24, 2021 22:20
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, I've got one last nitpick though.

stubs/mysqli.phpstub Show resolved Hide resolved
Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
Copy link
Collaborator

@weirdan weirdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@weirdan weirdan merged commit 55b2b6b into vimeo:master Nov 24, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 24, 2021

Thanks!

@kamil-tekiela
Copy link
Contributor Author

I'm not sure what happened to the docblock in mysqli.phpstub. Maybe I just didn't notice that it is indented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants