Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session_set_cookie_params signature changed in 8.0 #6932

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

kamil-tekiela
Copy link
Contributor

@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/ebba1bda24
<?php

session_set_cookie_params(0, null, null, null, null);
Psalm output (using commit 608e8d1):

ERROR: NullArgument - 3:30 - Argument 2 of session_set_cookie_params cannot be null, null value provided to parameter with type string

ERROR: NullArgument - 3:42 - Argument 4 of session_set_cookie_params cannot be null, null value provided to parameter with type bool

ERROR: NullArgument - 3:48 - Argument 5 of session_set_cookie_params cannot be null, null value provided to parameter with type bool

@weirdan
Copy link
Collaborator

weirdan commented Nov 16, 2021

You will also need to update CallMap.php (see https://psalm.dev/docs/contributing/editing_callmaps/ for details).

@kamil-tekiela
Copy link
Contributor Author

Is it correct now?

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 16, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 16, 2021

Is it correct now?

According to the CI it is.

@weirdan weirdan merged commit aabd96c into vimeo:master Nov 16, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 16, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants