Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow references to enum cases in class constants #6922

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Allow references to enum cases in class constants #6922

merged 1 commit into from
Nov 15, 2021

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 15, 2021

Refs #6471

@weirdan weirdan added release:fix The PR will be included in 'Fixes' section of the release notes enum labels Nov 15, 2021
@weirdan weirdan added this to the PHP 8.1 milestone Nov 15, 2021
@weirdan weirdan requested a review from orklah November 15, 2021 03:58
orklah
orklah reviewed Nov 15, 2021
View reviewed changes
tests/EnumTest.php
@@ -154,6 +154,26 @@ public function get(): string
[],
'8.1'
],
'SKIPPED-wildcardEnum' => [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skipped?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it doesn't work yet.

@weirdan weirdan merged commit 608e8d1 into vimeo:master Nov 15, 2021
@weirdan weirdan deleted the cases-references branch November 15, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
enum release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
PHP 8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@weirdan @orklah