SimpleXMLIterator is not always truthy #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that this is my first PR, heavily based off #6650. I'm not entirely sure what the ReconcilerTest does, so it may need changes. Please review, thanks |
|
I put it back to draft, I clicked on the wrong button :) Seems good at first glance |
orklah
added
the
release:fix
Then I'll set it ready for review (I was under the impression that was what draft was for, haven't made a PR on GH in a while) |
|
Draft is to signal maintainers you're not ready to merge. Usually for WIP PR. Thanks! That's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6865