make ignore falsable/nullable dependent on the config #6895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdan
added
the
release:fix
weirdan
reviewed
Nov 12, 2021
src/Psalm/Internal/PhpVisitor/Reflector/FunctionLikeDocblockParser.php
Outdated
Show resolved
Hide resolved
weirdan
approved these changes
Nov 12, 2021
orklah
force-pushed
the
ignore-falsable
branch
from
5b6f42e
to
1713fdd
Compare
orklah
force-pushed
the
ignore-falsable
branch
from
774117c
to
1464e8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix #6893 by slightly changing the meaning of our configs