Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load the ReturnTypeWillChange stubs for all versions to allow using it on every PHP version #6873

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Nov 9, 2021

This will fix #6854 and #6849

Tests are not 100% real because this particular issue depends on php version used to run Psalm as much as version used to analyse but I tested this with 8.0 and 8.1RC5 on my machine and it works

Fixes #6854
Fixes #6849

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 9, 2021
@orklah orklah merged commit de44319 into vimeo:master Nov 9, 2021
@derrabus
Copy link

derrabus commented Nov 9, 2021

Thank you very much for working on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
2 participants