Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phpcs SelfMemberReference rule, and applied #6845

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

sasezaki
Copy link
Contributor

@sasezaki sasezaki commented Nov 7, 2021

I found Type:: parseString(, surprisingly it includes space after ::.
https://github.com/vimeo/psalm/blob/4.12.0/tests/TypeParseTest.php

It can be forbid by Squiz.Classes.SelfMemberReference.SpaceAfter.

I belive whole Squiz.Classes.SelfMemberReference rule would be applicatable.

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 7, 2021
@weirdan weirdan merged commit 17ef25a into vimeo:master Nov 7, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 7, 2021

Thanks!

@sasezaki sasezaki deleted the cs_SelfMemberReference branch November 8, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants