don't consider calls to methods with assertions as Unused #6834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
orklah
force-pushed
the
unused-in-assert
branch
from
5802b69
to
9c9669e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #5735 and will fix #5528. If anyone understands mixins, I guess the fix for #3701 should be around those parts too.
I don't fully understands every check that's made here so I just excluded the error but I have the feeling like there would be improvements to be made here. For starter, I don't understand why https://github.com/vimeo/psalm/pull/6834/files#diff-af464bb3ab4e6193d8b7eec8d9c52b8be4e801fda844f86d0db7c9c0b2e63637R92 there is assertions, if_true assertions but not if_false_assertions here.