redis: add possible types for Redis#auth method
#10934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
|
I'm not sure Psalm can correctly process the attribute here, can you remove it just in case? |
|
ah I can, yes. Was thinking it might have benefits for tentative thingy. |
I was expecting that it might have a benefit regarding tentative types but it seems that psalm does not use that and thus was suggested to be removed. Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
weirdan
added
internal stubs/callmap
release:fix
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v6.0.0,
Redis#authalso accepts an array with 2 values where the first value represents theuserand the secondpassword.I am not sure if they accept
arrayas of 6.0 but as of the "official" stub,authdoes also accept an array with just the password:https://github.com/phpredis/phpredis/blob/f350dc342cb3520b2ee663664a22c25f29bc8aaf/redis.stub.php#L581-L594