Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update master from 5.x #10850

Draft
wants to merge 49 commits into
base: master
Choose a base branch
from
Draft

Update master from 5.x #10850

wants to merge 49 commits into from

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Mar 21, 2024

  • Use wider class-string when combining class strings with intersections
  • Forbid named arguments for ArrayAcccess methods
  • Allow more callable types as subtypes of callable
  • Don't crash on invalid templates
  • Added test for Method __callStatic() breaks asserts on 5.23 #10807
  • Resolve fail test Method __callStatic() breaks asserts on 5.23 #10807
  • Introduce TCallableInterface
  • add support for named arguments for filter_var and filter_input
  • Promoted properties missing in extended __construct should report PropertyNotSetInConstructor
  • report error for single param too since named args can even be used then
  • Fix PHP 8.1 deprecated calls not reported #7550
  • MissingClassConstType
  • Allow specifying flags to Codebase::isTypeContainedByType
  • cs-fix
  • [PHP 8.4] Fixes for implicit nullability deprecation
  • Fix undefined parent not reported in callable
  • fix tests running with other than called PHP binary if called with a non-default PHP binary
  • Explicitly set value in config to fix warning in tests
  • fix bad class
  • self
  • report invalid callable if callable cannot be called like this from current context
  • ParamNameMismatch not reported for __construct
  • When inside isset
  • Update baseline
  • Additional array fetch test case
  • Update tests/CallableTest.php
  • Update CallMap.php
  • Update CallMap_historical.php

weirdan and others added 30 commits March 9, 2024 20:32
@weirdan
Use wider class-string when combining class strings with intersections
739d87d 
Fixes vimeo#10799
@weirdan
Merge pull request vimeo#10800 from weirdan/10799-use-wider-classstring
005e318
@weirdan
Forbid named arguments for ArrayAcccess methods
00c2fef 
Fixes vimeo#10533
@weirdan
Merge pull request vimeo#10804 from weirdan/10533-no-named-arguments-…
c511185 
…for-array-access
@weirdan
Allow more callable types as subtypes of callable
20c7889 
Fixes vimeo#10461
@weirdan
Don't crash on invalid templates
4a2cf93 
Fixes vimeo#9596
@weirdan
Merge pull request vimeo#10806 from weirdan/9596-dont-crash-on-invali…
ae1d510 
…d-templates
@SCIF @weirdan
Added test for vimeo#10807
2a91bd6
@issidorov @weirdan
Resolve fail test vimeo#10807
fe42e88 
Resolved problem:
```
Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork
Psalm\Exception\CodeException: LessSpecificReturnStatement
The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty
```
@weirdan
Merge pull request vimeo#10812 from issidorov/bug-10807
8471a89
@weirdan
Merge branch '5.23.x' into 5.x
4ea41cb
@weirdan
Introduce TCallableInterface
c9468b6 
`TClosure` does not implement it at this point. It's intentional, to maintain the
separation between callables and closures that our code relies on.
@pilif
add support for named arguments for filter_var and filter_input
debffec 
this fixes vimeo#10809
@kkmuffme
Promoted properties missing in extended __construct should report Pro…
9c5af0f 
…pertyNotSetInConstructor

Fix vimeo#10786
@kkmuffme
report error for single param too since named args can even be used then
a2307ac
@kkmuffme
Fix vimeo#7550
c174e35
@jack-worman
MissingClassConstType
c7fc76e
@danog
Allow specifying flags to Codebase::isTypeContainedByType
ad87c2e
@danog
cs-fix
b431e5f
@Ayesh
[PHP 8.4] Fixes for implicit nullability deprecation
431977c 
Fixes all issues that emits a deprecation notice on PHP 8.4.

See:
 - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types)
 - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
@kkmuffme
Fix undefined parent not reported in callable
ff168a9 
Fix vimeo#10836
@kkmuffme
fix tests running with other than called PHP binary if called with a …
8815463 
…non-default PHP binary

e.g. you run the tests with a php83 executable but your default php is PHP 7.4, it will suddenly change while running the tests leading to false positive errors
@danog
Merge pull request vimeo#10842 from kkmuffme/fix-tests-using-other-th…
e8e1f47 
…an-called-from-php-version

fix tests running with other than called PHP binary if called with a non-default PHP binary
@kkmuffme
Explicitly set value in config to fix warning in tests
ea825c6
@kkmuffme
fix bad class
8efbf38
@danog
Merge pull request vimeo#10843 from kkmuffme/fix-psalm-6-notice-in-te…
45d9fbe 
…sts-config

Explicitly set value in config to fix warning in tests
@weirdan
Merge pull request vimeo#10832 from Ayesh/php84/nullability
644ef8d
@weirdan
Merge pull request vimeo#10829 from vimeo/isTypeContainedByType_flags
4b7957b
@weirdan
Merge pull request vimeo#10805 from weirdan/10461-allow-more-callable…
f61c7e1 
…-types-as-subtypes-of-callable
@kkmuffme @weirdan
self, parent and static in callable are deprecated since PHP 8.2
a59248f 
Fix vimeo#10837
kkmuffme and others added 18 commits March 20, 2024 01:02
@kkmuffme @weirdan
report invalid callable if callable cannot be called like this from c…
e83530a 
…urrent context

Fix vimeo#10823
Fix vimeo#8509
@weirdan
Merge pull request vimeo#10838 from kkmuffme/undefined-parent-not-rep…
e3d5526 
…orted-in-callable
@weirdan
Merge pull request vimeo#10824 from kkmuffme/update-misc-deprecated-a…
c5adc51 
…rg-types-PHP81-83
@weirdan
Merge pull request vimeo#10822 from kkmuffme/report-param-name-mismat…
98eab1f 
…ch-for-single-param-too
@weirdan
Merge pull request vimeo#10815 from pilif/filter_var-named-args
2c1ac98
@weirdan
Merge pull request vimeo#10828 from jack-worman/MissingClassConstType
3a1b10f
@kkmuffme @weirdan
ParamNameMismatch not reported for __construct
9cfce37 
Fix vimeo#10784
@weirdan
Merge pull request vimeo#10821 from kkmuffme/consistent-constructor-p…
cc5ad67 
…aram-name-mismatch
@edsrzf @weirdan
When inside isset, array fetch can return null
86173d2 
This prevents false positive for various types of issues inside empty,
such as RedundantConditionGivenDocblockType and TypeDoesNotContainType.
@edsrzf @weirdan
Update baseline
30e797b
@edsrzf @weirdan
Additional array fetch test case
4b707d1
@weirdan
Merge pull request vimeo#10756 from edsrzf/array-isset
70530d6
@weirdan
Merge pull request vimeo#10817 from kkmuffme/promoted-properties-not-…
b47449f 
…set-in-extended-constructor
@weirdan
Update tests/CallableTest.php
375fe32
@weirdan
Merge pull request vimeo#10839 from kkmuffme/misc-class-callable-erro…
4266a8e 
…rs-not-reported
@ThomasLandauer
Update CallMap.php
2f90881
@ThomasLandauer
Update CallMap_historical.php
2ae91aa
@weirdan
Merge pull request vimeo#10847 from ThomasLandauer/patch-1
63ea4de
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Mar 21, 2024
@weirdan weirdan requested review from danog and orklah March 21, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danog danog Awaiting requested review from danog

@orklah orklah Awaiting requested review from orklah

Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@weirdan @SCIF @issidorov @pilif @kkmuffme @jack-worman @danog @Ayesh @edsrzf @ThomasLandauer