Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misc callable bugs #10370

Merged
merged 15 commits into from Nov 22, 2023
Merged

Fix misc callable bugs #10370

merged 15 commits into from Nov 22, 2023

Commits on Nov 18, 2023

  1. Fix array_filter callback type 

    Fix vimeo#9068
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    2 Configuration menu
    Copy the full SHA
    f3e9263 View commit details
    Browse the repository at this point in the history

  2. remove now invalid test

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    be85cb0 View commit details
    Browse the repository at this point in the history

  3. Fix vimeo#8919

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    506fb9c View commit details
    Browse the repository at this point in the history

  4. Fix vimeo#10371

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ba79797 View commit details
    Browse the repository at this point in the history

  5. Fix param providers for native methods not working Fix array_filter p… 

    …arams callable incorrect required params depending on the 3rd argument value (at this commit psalm doesn't report an error, due to vimeo#8438, which gets fixed by this PR later on though) Fix vimeo#3047 and further improve types for array_multisort and add errors for invalid params Fix SimpleTypeInferer failing on bitwise operations with constants
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    c5655c5 View commit details
    Browse the repository at this point in the history

  6. Fixed https://psalm.dev/r/7f112fd745 - MethodComparator only reported… 

    … an error for this if the parent class was user defined (= not in stubs), which is wrong, since this will cause a fatal error when running the code
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0252bbb View commit details
    Browse the repository at this point in the history

  7. Fixed ReturnTypeWillChange false positive https://psalm.dev/r/91c6992bf1 

     with missing return type signature
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    5eacd30 View commit details
    Browse the repository at this point in the history

  8. Fix that files passed via CLI but are not in projectFiles reported on… 

    …ly a limited, random selection of errors instead of all - treat all files passed as CLI args as if they were in projectFiles
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    92bcc5c View commit details
    Browse the repository at this point in the history

  9. Fix for classes what vimeo#8503 fixed for functions (as some issues d… 

    …idn't report for other reasons, which were solved since then)
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    cea98ff View commit details
    Browse the repository at this point in the history

  10. Fix vimeo#6085

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0ca2d4f View commit details
    Browse the repository at this point in the history

  11. Fix optional args not enforced in callable (fix for non-closure/arrow… 

    … functions of vimeo#8438) Fix array callables not treated as callable https://psalm.dev/r/23f3787207 (this is needed to fix the optional args enforcement for array callables too)
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    adb8677 View commit details
    Browse the repository at this point in the history

  12. Fix potential cache race conditions/cache not deleted with non-lowerc… 

    …ase file paths and add missing docs
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    be6028d View commit details
    Browse the repository at this point in the history

  13. revert 804087b of vimeo#10026

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    3299689 View commit details
    Browse the repository at this point in the history

  14. Remove tests for partially stubbed classes introduced in vimeo#849, a… 

    …s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    fd2f876 View commit details
    Browse the repository at this point in the history

  15. suppress false positive

    @kkmuffme
    kkmuffme committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    00bed51 View commit details
    Browse the repository at this point in the history