Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improve Throwable::getTrace() return type #7830

Closed
AndrolGenhald opened this issue Mar 30, 2022 · 0 comments · Fixed by #7864
Closed

Further improve Throwable::getTrace() return type #7830

AndrolGenhald opened this issue Mar 30, 2022 · 0 comments · Fixed by #7864
Labels
bug easy problems Issues that can be fixed without background knowledge of Psalm good first issue internal stubs/callmap

Comments

@AndrolGenhald
Copy link
Collaborator

AndrolGenhald commented Mar 30, 2022 •
edited

per phpstan/phpstan-src#914 (comment) file is optional

Originally posted by @staabm in #7798 (comment)

@staabm staabm 4 days ago

and class can be narrowed to class-string.

let me steal this more precise type-union-type into phpstan ;)

@AndrolGenhald AndrolGenhald 4 days ago

line is optional as well apparently.
@AndrolGenhald AndrolGenhald changed the title per https://github.com/phpstan/phpstan-src/pull/914#issuecomment-1007995307 file is optional Further improve Throwable::getTrace() return type Mar 30, 2022
@AndrolGenhald AndrolGenhald added bug easy problems Issues that can be fixed without background knowledge of Psalm good first issue internal stubs/callmap labels Mar 30, 2022
@hirokinoue hirokinoue mentioned this issue Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy problems Issues that can be fixed without background knowledge of Psalm good first issue internal stubs/callmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Further improve Throwable::getTrace() return type hirokinoue/psalm
1 participant
@AndrolGenhald