Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDOException extends RuntimeException and can use int code errors #7673

Merged
merged 1 commit into from Feb 23, 2022
Merged

PDOException extends RuntimeException and can use int code errors #7673

merged 1 commit into from Feb 23, 2022

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Feb 14, 2022 •
edited

Closes #7672

@VincentLanglet VincentLanglet mentioned this pull request Feb 14, 2022
Closed
@orklah
Copy link
Collaborator

orklah commented Feb 20, 2022

@VincentLanglet what's the status of this? It seems to still be in draft on your side

@VincentLanglet
Copy link
Contributor Author

@VincentLanglet what's the status of this? It seems to still be in draft on your side

The PR is ready and I made the same on the Phpstan. I was just waiting an answer/merge from ondrej on the Phpstan PR before. In order to be sure that both psalm and phpstan will have the same behavior.

@VincentLanglet VincentLanglet mentioned this pull request Feb 22, 2022
Merged
@VincentLanglet VincentLanglet marked this pull request as ready for review February 23, 2022 10:10
@VincentLanglet
Copy link
Contributor Author

Seems like the PR phpstan/phpstan-src#1018 will be accepted on phpstan

@orklah orklah added release:fix The PR will be included in 'Fixes' section of the release notes and removed PR: Needs work labels Feb 23, 2022
@orklah orklah merged commit 3a85f49 into vimeo:4.x Feb 23, 2022
@orklah
Copy link
Collaborator

orklah commented Feb 23, 2022

Thanks!

@VincentLanglet VincentLanglet mentioned this pull request Dec 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrolGenhald AndrolGenhald AndrolGenhald left review comments

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type for RuntimeException::getCode()
3 participants
@VincentLanglet @orklah @AndrolGenhald