Incorrect type for RuntimeException::getCode()

[AndrolGenhald]

https://psalm.dev/r/512ac9662c https://3v4l.org/RBCW0

@VincentLanglet re #7390

I suggest copy/pasting

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallReturnTypeFetcher.php

Line 99 in 06ce3ad

&& $premixin_method_id->fq_class_name !== Exception::class

and doing a RuntimeException::class check as well.

Also, PDOException should return int|string (or maybe 0|string but I'm not sure): https://3v4l.org/9vu2u

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/512ac9662c

<?php

try {
    throw new PDOException();
} catch (RuntimeException $e) {
    $code = $e->getCode();
    /** @psalm-trace $code */;
}

Psalm output (using commit 5aa06ae):

INFO: Trace - 7:30 - $code: int

INFO: UnusedVariable - 6:5 - $code is never referenced or the value is not used

[VincentLanglet]

I followed PHPStan on this https://phpstan.org/r/42089d28-dbaa-4b67-ac00-154372ce55a8
But indeed, it need to be fixed.

[orklah]

PDOException is a child of RuntimeException? :o

What a mess :( ...

[VincentLanglet]

I just opened an issue phpstan/phpstan#6651 and a PR phpstan/phpstan-src#1018 on PHPStan. I'll hope it will be reviewed quickly to be sure phpstan is going in the same direction.

Do you want to make the fix on psalm @AndrolGenhald or should I ?

[AndrolGenhald]

You can go ahead, I'm in the middle of rewriting TryAnalyzer.

[VincentLanglet]

I made #7673. But I would recommend to wait for a response from the phpstan-side in order to copy the behavior.