Fix preg_match_all stub #4325
Merged
Fix preg_match_all stub #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add |
|
Thanks! |
muglug
pushed a commit
that referenced
this pull request
Oct 15, 2020
* preg_match_all can return false * Test for preg_match_all returning false * Fix test * Add @psalm-ignore-falsable-return
danog
pushed a commit
to danog/psalm
that referenced
this pull request
Jan 29, 2021
* preg_match_all can return false * Test for preg_match_all returning false * Fix test * Add @psalm-ignore-falsable-return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preg_match_allcan return false given a bad pattern.This PR fixes the stub, and adds a test for it. The test triggers a warning, so I suppress that since we're only interested in the
falsereturn value.