Fix preg_match_all stub (vimeo#4325)

* preg_match_all can return false * Test for preg_match_all returning false * Fix test * Add @psalm-ignore-falsable-return
danog · Jan 29, 2021 · fb505df · fb505df
1 parent d4ccfcf
commit fb505df
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/stubs/CoreGenericFunctions.phpstub b/stubs/CoreGenericFunctions.phpstub
@@ -760,7 +760,8 @@ function preg_replace_callback($search, $replace, $subject, int $limit = -1, &$c
  *              )
  *          )
  *        ) $matches
- * @return int
+ * @return int|false
+ * @psalm-ignore-falsable-return
  */
 function preg_match_all($pattern, $replace, &$matches = [], int $flags = 1, int $offset = 0) {}
 

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1341,6 +1341,15 @@ function foo(string $input): array {
                         return $matches[0];
                     }'
             ],
+            'pregMatchAllReturnsFalse' => [
+                '<?php
+                    /**
+                     * @return int|false
+                     */
+                    function badpattern() {
+                        return @preg_match_all("foo", "foo", $matches);
+                    }'
+            ],
             'strposAllowDictionary' => [
                 '<?php
                     function sayHello(string $format): void {