Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter selected text to prevent invalid XML #4234

Merged
merged 1 commit into from Sep 22, 2020
Merged

Filter selected text to prevent invalid XML #4234

merged 1 commit into from Sep 22, 2020

Conversation

aheart
Copy link
Contributor

@aheart aheart commented Sep 22, 2020

The current JUnit formatter occasionally produces invalid XML.
This happens for code snippets that contain two ampersands "&&".

psalm.junit.xml:19436: parser error : xmlParseEntityRef: no name
selected_text: if (!$request->isMethod(Request::METHOD_GET) & !$request->isMe
                                                                ^

@muglug muglug merged commit 8da6feb into vimeo:master Sep 22, 2020
@muglug
Copy link
Collaborator

muglug commented Sep 22, 2020

Thanks!

muglug pushed a commit that referenced this pull request Oct 7, 2020
@aheart @muglug
Filter selected text to prevent invalid XML (#4234)
484c34a
danog pushed a commit to danog/psalm that referenced this pull request Jan 29, 2021
@aheart @danog
Filter selected text to prevent invalid XML (vimeo#4234)
19a2577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aheart @muglug