Filter selected text to prevent invalid XML (#4234)

vimeo · Oct 7, 2020 · 484c34a · 484c34a
1 parent 49b4fe0
commit 484c34a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/Psalm/Report/JunitReport.php b/src/Psalm/Report/JunitReport.php
@@ -168,7 +168,7 @@ private function dataToOutput(IssueData $data): string
         $ret = 'message: ' . htmlspecialchars(trim($data->message), ENT_XML1 | ENT_QUOTES) . "\n";
         $ret .= 'type: ' . trim($data->type) . "\n";
         $ret .= 'snippet: ' . htmlspecialchars(trim($data->snippet), ENT_XML1 | ENT_QUOTES) . "\n";
-        $ret .= 'selected_text: ' . trim($data->selected_text) . "\n";
+        $ret .= 'selected_text: ' . htmlspecialchars(trim($data->selected_text)) . "\n";
         $ret .= 'line: ' . $data->line_from . "\n";
         $ret .= 'column_from: ' . $data->column_from . "\n";
         $ret .= 'column_to: ' . $data->column_to . "\n";