Merge pull request #6972 from orklah/unused-throws

prevent Psalm from considering throwing methods as unused just because they're immutable
vimeo · Nov 22, 2021 · eca56c0 · eca56c0
2 parents e13c48a + d8fcd78
commit eca56c0
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallPurityAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodCallPurityAnalyzer.php
@@ -112,6 +112,7 @@ public static function analyze(
                     && !$method_storage->assertions
                     && !$method_storage->if_true_assertions
                     && !$method_storage->if_false_assertions
+                    && !$method_storage->throws
                 ) {
                     if (IssueBuffer::accepts(
                         new \Psalm\Issue\UnusedMethodCall(

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -1162,6 +1162,27 @@ private function assert(?string $val): void {
                     $a = new A();
                     echo $a->getVal(null);',
             ],
+            'NotUnusedWhenThrows' => [
+                '<?php
+                    declare(strict_types=1);
+
+                    /** @psalm-immutable */
+                    final class UserList
+                    {
+                        /**
+                         * @throws InvalidArgumentException
+                         */
+                        public function validate(): void
+                        {
+                            // Some validation happens here
+                            throw new \InvalidArgumentException();
+                        }
+                    }
+
+                    $a = new UserList();
+                    $a->validate();
+                    ',
+            ],
             '__halt_compiler_no_usage_check' => [
                 '<?php
                     exit(0);