Merge pull request #7002 from orklah/listkeyedarray

Disable list flag for TKeyedArray after unset
vimeo · Nov 26, 2021 · a27e729 · a27e729
2 parents 2fbad1b + 4f223db
commit a27e729
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/UnsetAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/UnsetAnalyzer.php
@@ -50,6 +50,7 @@ public static function analyze(
                                 || $var->dim instanceof PhpParser\Node\Scalar\LNumber
                             ) {
                                 if (isset($atomic_root_type->properties[$var->dim->value])) {
+                                    $atomic_root_type->is_list = false;
                                     unset($atomic_root_type->properties[$var->dim->value]);
                                     $root_type->bustCache(); //remove id cache
                                 }

diff --git a/tests/ArrayAccessTest.php b/tests/ArrayAccessTest.php
@@ -1024,6 +1024,13 @@ function f($p): int {
                         return $p["name"];
                     }'
             ],
+            'unsetListKeyedArrayDisableListFlag' => [
+                '<?php
+                $a = ["a", "b"];
+                unset($a[0]);
+                ',
+                'assertions' => ['$a===' => 'array{1: "b"}']
+            ],
         ];
     }