Always check unused methods and properties

vimeo · Dec 22, 2022 · 9add80a · 9add80a
1 parent 390da64
commit 9add80a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Psalm/Internal/Codebase/ClassLikes.php b/src/Psalm/Internal/Codebase/ClassLikes.php
@@ -860,10 +860,9 @@ public function consolidateAnalyzedData(Methods $methods, ?Progress $progress, b
                             ),
                             $classlike_storage->suppressed_issues,
                         );
-                    } else {
-                        $this->checkMethodReferences($classlike_storage, $methods);
-                        $this->checkPropertyReferences($classlike_storage);
                     }
+                    $this->checkMethodReferences($classlike_storage, $methods);
+                    $this->checkPropertyReferences($classlike_storage);
                 }
 
                 $this->findPossibleMethodParamTypes($classlike_storage);

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -160,7 +160,7 @@ function bar(): void{
         $this->analyzeFile($file_path, new Context(), false);
         $this->project_analyzer->consolidateAnalyzedData();
 
-        $this->assertSame(3, IssueBuffer::getErrorCount());
+        $this->assertSame(4, IssueBuffer::getErrorCount());
         $issue = IssueBuffer::getIssuesDataForFile($file_path)[2];
         $this->assertSame('UnusedClass', $issue->type);
         $this->assertSame(10, $issue->line_from);