#8200 - simplify ExistingAtomicStaticCallAnalyzer::hasStaticType()

vimeo · Jul 12, 2022 · 931b3bb · 931b3bb
1 parent ecbceb1
commit 931b3bb
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/...nal/Analyzer/Statements/Expression/Call/StaticMethod/ExistingAtomicStaticCallAnalyzer.php b/...nal/Analyzer/Statements/Expression/Call/StaticMethod/ExistingAtomicStaticCallAnalyzer.php
@@ -35,7 +35,6 @@
 use Psalm\Type\Union;
 
 use function array_map;
-use function assert;
 use function count;
 use function explode;
 use function in_array;
@@ -628,21 +627,14 @@ private static function getMethodReturnType(
      */
     private static function hasStaticInType(Type\TypeNode $type): bool
     {
-        assert($type instanceof Atomic || $type instanceof Union);
-        $union_parts = $type instanceof Union
-            ? $type->getAtomicTypes()
-            : [ $type ];
+        if ($type instanceof TNamedObject && $type->value === 'static') {
+            return true;
+        }
 
-        foreach ($union_parts as $atomic_type) {
-            if ($atomic_type instanceof TNamedObject && $atomic_type->value === 'static') {
+        foreach ($type->getChildNodes() as $child_type) {
+            if (self::hasStaticInType($child_type)) {
                 return true;
             }
-
-            foreach ($atomic_type->getChildNodes() as $child_type) {
-                if (self::hasStaticInType($child_type)) {
-                    return true;
-                }
-            }
         }
 
         return false;