Merge pull request #8583 from gphargreaves/#8484/fix-datetimeimmutabl…

…e-sub Correct return type of DateTimeImmutable sub method stub
vimeo · Oct 15, 2022 · 9218017 · 9218017
2 parents dbb8815 + 8849e8c
commit 9218017
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/stubs/CoreImmutableClasses.phpstub b/stubs/CoreImmutableClasses.phpstub
@@ -58,10 +58,8 @@ class DateTimeImmutable implements DateTimeInterface
 
     /**
      * @psalm-mutation-free
-     * @return static|false this method can fail in case an {@see DateInterval} with relative
-     *                      week days is passed in.
-     *
-     * @see https://github.com/php/php-src/blob/534127d3b22b193ffb9511c4447584f0d2bd4e24/ext/date/php_date.c#L3157-L3160
+     * @return static
+
      */
     public function sub(DateInterval $interval) {}
 

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -271,7 +271,7 @@ final class MyDate extends DateTimeImmutable {}
 
                     $b = (new DateTimeImmutable())->modify("+3 hours");',
                 'assertions' => [
-                    '$yesterday' => 'MyDate|false',
+                    '$yesterday' => 'MyDate',
                     '$b' => 'DateTimeImmutable',
                 ],
             ],