Merge pull request #8650 from VincentLanglet/serialize

Do not report serialize as unused
vimeo · Nov 2, 2022 · 85b5436 · 85b5436
2 parents 761d67f + 0bdfc4b
commit 85b5436
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Codebase/Functions.php b/src/Psalm/Internal/Codebase/Functions.php
@@ -518,12 +518,27 @@ public function isCallMapFunctionPure(
 
             //gettext
             'bindtextdomain',
+
+            // unserialize
+            'unserialize'
         ];
 
         if (in_array(strtolower($function_id), $impure_functions, true)) {
             return false;
         }
 
+        if ($function_id === 'serialize' && isset($args[0]) && $type_provider) {
+            $serialize_type = $type_provider->getType($args[0]->value);
+
+            if ($serialize_type) {
+                foreach ($serialize_type->getAtomicTypes() as $atomic_serialize_type) {
+                    if ($atomic_serialize_type->isObjectType()) {
+                        return false;
+                    }
+                }
+            }
+        }
+
         if (strpos($function_id, 'image') === 0) {
             return false;
         }

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -737,6 +737,31 @@ public function unserialize($_serialized) : void {}
 
                     new Foo();'
             ],
+            'ignoreSerializeAndUnserialize' => [
+                '<?php
+                    class Foo
+                    {
+                        public function __sleep(): array
+                        {
+                            throw new BadMethodCallException();
+                        }
+                        public function __wakeup(): void
+                        {
+                            throw new BadMethodCallException();
+                        }
+                    }
+
+                    function test(): bool {
+                        try {
+                            serialize(new Foo());
+                            unserialize("");
+                        } catch (\Throwable) {
+                            return false;
+                        }
+
+                        return true;
+                    }'
+            ],
             'useIteratorMethodsWhenCallingForeach' => [
                 '<?php
                     /** @psalm-suppress UnimplementedInterfaceMethod */