Merge pull request #7350 from orklah/hrtime3

set the is_list flag for the array inferred for hrtime
vimeo · Jan 8, 2022 · 771fbfa · 771fbfa
2 parents a9bc132 + 48ebbe8
commit 771fbfa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallReturnTypeFetcher.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/FunctionCallReturnTypeFetcher.php
@@ -331,6 +331,7 @@ private static function getReturnTypeFromCallMapWithArgs(
                         Type::getInt()
                     ]);
                     $keyed_array->sealed = true;
+                    $keyed_array->is_list = true;
                     return new Union([$keyed_array]);
 
                 case 'get_called_class':
@@ -446,6 +447,7 @@ private static function getReturnTypeFromCallMapWithArgs(
                             Type::getInt()
                         ]);
                         $keyed_array->sealed = true;
+                        $keyed_array->is_list = true;
 
                         if ((string) $first_arg_type === 'false') {
                             return new Union([$keyed_array]);

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1054,9 +1054,9 @@ class Props {
                     $d = hrtime(false);',
                 'assertions' => [
                     '$a' => 'int',
-                    '$b' => 'array{0: int, 1: int}',
-                    '$c' => 'array{0: int, 1: int}|int',
-                    '$d' => 'array{0: int, 1: int}',
+                    '$b' => 'array{int, int}',
+                    '$c' => 'array{int, int}|int',
+                    '$d' => 'array{int, int}',
                 ],
             ],
             'PHP73-hrtimeCanBeFloat' => [