Fix #4154 - treat literal numeric strings as numeric

vimeo · Sep 8, 2020 · 712a222 · 712a222
1 parent b84ef43
commit 712a222
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/Psalm/Type/Atomic.php b/src/Psalm/Type/Atomic.php
@@ -45,6 +45,7 @@
 use Psalm\Type\Atomic\TIterable;
 use Psalm\Type\Atomic\TList;
 use Psalm\Type\Atomic\TLiteralClassString;
+use Psalm\Type\Atomic\TliteralString;
 use Psalm\Type\Atomic\TMixed;
 use Psalm\Type\Atomic\TNamedObject;
 use Psalm\Type\Atomic\TNever;
@@ -289,7 +290,8 @@ public function isNumericType(): bool
         return $this instanceof TInt
             || $this instanceof TFloat
             || $this instanceof TNumericString
-            || $this instanceof TNumeric;
+            || $this instanceof TNumeric
+            || ($this instanceof TLiteralString && \is_numeric($this->value));
     }
 
     public function isObjectType(): bool

diff --git a/tests/TypeReconciliation/ReconcilerTest.php b/tests/TypeReconciliation/ReconcilerTest.php
@@ -166,6 +166,14 @@ public function providerTestTypeIsContainedBy()
                 'array<empty, empty>',
                 'array{a?: string, b?: string}',
             ],
+            'literalNumericStringInt' => [
+                '"0"',
+                'numeric',
+            ],
+            'literalNumericString' => [
+                '"10.03"',
+                'numeric',
+            ],
         ];
     }
 }