Merge pull request #7135 from klimick/fix-closure-param-type-inference

Fix type inference of closure params
vimeo · Dec 11, 2021 · 6632ddf · 6632ddf
2 parents b7a1528 + 603e1c9
commit 6632ddf
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 5 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentsAnalyzer.php
@@ -181,8 +181,6 @@ public static function analyze(
 
             if (($arg->value instanceof PhpParser\Node\Expr\Closure
                     || $arg->value instanceof PhpParser\Node\Expr\ArrowFunction)
-                && $template_result
-                && $template_result->lower_bounds
                 && $param
                 && !$arg->value->getDocComment()
             ) {
@@ -191,7 +189,7 @@ public static function analyze(
                     $args,
                     $method_id,
                     $context,
-                    $template_result,
+                    $template_result ?? new TemplateResult([], []),
                     $argument_offset,
                     $arg,
                     $param

diff --git a/tests/CallableTest.php b/tests/CallableTest.php
@@ -63,6 +63,28 @@ function(string $a) {
                 'error_levels' => [],
                 '7.4',
             ],
+            'inferArgFromClassContext' => [
+                '<?php
+                    final class Calc
+                    {
+                        /**
+                         * @param Closure(int, int): int $_fn
+                         */
+                        public function __invoke(Closure $_fn): int
+                        {
+                            return $_fn(42, 42);
+                        }
+                    }
+
+                    $calc = new Calc();
+
+                    $a = $calc(fn($a, $b) => $a + $b);',
+                'assertions' => [
+                    '$a' => 'int',
+                ],
+                'error_levels' => [],
+                '7.4',
+            ],
             'varReturnType' => [
                 '<?php
                     $add_one = function(int $a) : int {

diff --git a/tests/FunctionCallTest.php b/tests/FunctionCallTest.php
@@ -1377,8 +1377,6 @@ function (array $matches) : string {
                 '<?php
                     /**
                      * @param string[] $ids
-                     * @psalm-suppress MissingClosureReturnType
-                     * @psalm-suppress MixedArgumentTypeCoercion
                      */
                     function(array $ids): array {
                         return \preg_replace_callback(