Skip to content

Commit

Permalink
assign keys to variable for better performance
Browse files Browse the repository at this point in the history
improves performance by ~1-1.5%
  • Loading branch information
kkmuffme committed Jun 28, 2022
1 parent 4048bb9 commit 57239a7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Psalm/Internal/Algebra.php
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,15 @@ public static function simplifyCNF(array $clauses): array
if (!$clause_a->reconcilable || $clause_a->wedge) {
continue;
}
$clause_a_keys = array_keys($clause_a->possibilities);

if (count($clause_a->possibilities) !== 1 || count(array_values($clause_a->possibilities)[0]) !== 1) {
foreach ($cloned_clauses as $clause_b) {
if ($clause_a === $clause_b || !$clause_b->reconcilable || $clause_b->wedge) {
continue;
}

if (array_keys($clause_a->possibilities) === array_keys($clause_b->possibilities)) {
if ($clause_a_keys === array_keys($clause_b->possibilities)) {
$opposing_keys = [];

foreach ($clause_a->possibilities as $key => $a_possibilities) {
Expand Down

0 comments on commit 57239a7

Please sign in to comment.