Merge pull request #7311 from orklah/inArrayAssertionOnTemplate

don't crash when pushing a template to in_array
vimeo · Jan 5, 2022 · 3dbc039 · 3dbc039
2 parents e41fc67 + a6a0769
commit 3dbc039
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php b/src/Psalm/Internal/Analyzer/Statements/Expression/AssertionFinder.php
@@ -3556,7 +3556,7 @@ private static function getInarrayAssertions(
                         // - The array may have one of the types but not the others.
                         //
                         // NOTE: the negation of the negation is the original assertion.
-                        if ($value_type->getId() !== '' && !$value_type->isMixed()) {
+                        if ($value_type->getId() !== '' && !$value_type->isMixed() && !$value_type->hasTemplate()) {
                             $assertions[] = 'in-array-' . $value_type->getId();
                         }
                     } else {

diff --git a/tests/AssertAnnotationTest.php b/tests/AssertAnnotationTest.php
@@ -1898,6 +1898,29 @@ function assertBarNotNull(Foo $foo): bool
                     function requiresString(string $_str): void {}
                 ',
             ],
+            'assertInArrayWithTemplateDontCrash' => [
+                '<?php
+                    class A{
+                        /**
+                         * @template T
+                         * @param array<T> $objects
+                         * @return array<T>
+                         */
+                        private function uniquateObjects(array $objects) : array
+                        {
+                            $uniqueObjects = [];
+                            foreach ($objects as $object) {
+                                if (in_array($object, $uniqueObjects, true)) {
+                                    continue;
+                                }
+                                $uniqueObjects[] = $object;
+                            }
+
+                            return $uniqueObjects;
+                        }
+                    }
+                ',
+            ],
             'assertionOnMagicProperty' => [
                 '<?php
                     /**