Merge pull request #8473 from kkmuffme/detailed-superglobal-types

make superglobals more specific

docs/running_psalm/issues/MixedArgument.md

@@ -6,5 +6,5 @@ Emitted when Psalm cannot determine the type of an argument
 <?php
 
 function takesInt(int $i) : void {}
-takesInt($_GET['foo']);
+takesInt($GLOBALS['foo']);
 ```

docs/running_psalm/issues/MixedArrayAccess.md

@@ -5,5 +5,5 @@ Emitted when trying to access an array offset on a value whose type Psalm cannot
 ```php
 <?php
 
-echo $_GET['foo'][0];
+echo $GLOBALS['foo'][0];
 ```

docs/running_psalm/issues/MixedArrayAssignment.md

@@ -5,5 +5,5 @@ Emitted when trying to assign a value to an array offset on a value whose type P
 ```php
 <?php
 
-$_GET['foo'][0] = "5";
+$GLOBALS['foo'][0] = "5";
 ```

docs/running_psalm/issues/MixedArrayOffset.md

@@ -5,5 +5,5 @@ Emitted when attempting to access an array offset where Psalm cannot determine t
 ```php
 <?php
 
-echo [1, 2, 3][$_GET['foo']];
+echo [1, 2, 3][$GLOBALS['foo']];
 ```

docs/running_psalm/issues/MixedAssignment.md

@@ -6,7 +6,7 @@ cannot infer a type more specific than `mixed`.
 ```php
 <?php
 
-$a = $_GET['foo'];
+$a = $GLOBALS['foo'];
 ```
 
 ## How to fix
@@ -16,7 +16,7 @@ The above example can be fixed in a few ways – by adding an `assert` call:
 ```php
 <?php
 
-$a = $_GET['foo'];
+$a = $GLOBALS['foo'];
 assert(is_string($a));
 ```
 
@@ -25,7 +25,7 @@ or by adding an explicit cast:
 ```php
 <?php
 
-$a = (string) $_GET['foo'];
+$a = (string) $GLOBALS['foo'];
 ```
 
 or by adding a docblock
@@ -34,5 +34,5 @@ or by adding a docblock
 <?php
 
 /** @var string */
-$a = $_GET['foo'];
+$a = $GLOBALS['foo'];
 ```

docs/running_psalm/issues/MixedClone.md

@@ -5,5 +5,5 @@ Emitted when trying to clone a value whose type is not known
 ```php
 <?php
 
-$a = clone $_GET["a"];
+$a = clone $GLOBALS["a"];
 ```

docs/running_psalm/issues/MixedFunctionCall.md

@@ -6,6 +6,6 @@ Emitted when calling a function on a value whose type Psalm cannot infer.
 <?php
 
 /** @var mixed */
-$a = $_GET['foo'];
+$a = $GLOBALS['foo'];
 $a();
 ```

docs/running_psalm/issues/MixedInferredReturnType.md

@@ -6,6 +6,6 @@ Emitted when Psalm cannot determine a function's return type
 <?php
 
 function foo() : int {
-    return $_GET['foo'];
+    return $GLOBALS['foo'];
 }
 ```

docs/running_psalm/issues/MixedOperand.md

@@ -5,7 +5,7 @@ Emitted when Psalm cannot infer a type for an operand in any calculated expressi
 ```php
 <?php
 
-echo $_GET['foo'] + "hello";
+echo $GLOBALS['foo'] + "hello";
 ```
 
 ## Why it’s bad

docs/running_psalm/issues/MixedReturnStatement.md

@@ -6,6 +6,6 @@ Emitted when Psalm cannot determine the type of a given return statement
 <?php
 
 function foo() : int {
-    return $_GET['foo']; // emitted here
+    return $GLOBALS['foo']; // emitted here
 }
 ```

docs/running_psalm/issues/MixedStringOffsetAssignment.md

@@ -5,5 +5,5 @@ Emitted when assigning a value on a string using a value for which Psalm cannot
 ```php
 <?php
 
-"hello"[0] = $_GET['foo'];
+"hello"[0] = $GLOBALS['foo'];
 ```

src/Psalm/Codebase.php

@@ -1088,7 +1088,7 @@ public function getSymbolInformation(string $file_path, string $symbol): ?array
             }
 
             if (strpos($symbol, '$') === 0) {
-                $type = VariableFetchAnalyzer::getGlobalType($symbol);
+                $type = VariableFetchAnalyzer::getGlobalType($symbol, $this->analysis_php_version_id);
                 if (!$type->isMixed()) {
                     return ['type' => '<?php ' . $type];
                 }