Default to using inferred type unless in late static binding context.

vimeo · Dec 13, 2021 · 1d3dfe9 · 1d3dfe9
1 parent 0f899ac
commit 1d3dfe9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Codebase/ClassLikes.php b/src/Psalm/Internal/Codebase/ClassLikes.php
@@ -1635,7 +1635,7 @@ public function getClassConstantType(
         int $visibility,
         ?StatementsAnalyzer $statements_analyzer = null,
         array $visited_constant_ids = [],
-        bool $late_static_binding = true
+        bool $late_static_binding = false
     ): ?Type\Union {
         $class_name = strtolower($class_name);
 

diff --git a/tests/ConstantTest.php b/tests/ConstantTest.php
@@ -304,14 +304,17 @@ function foo(array $arg): void {}
             'lateConstantResolutionParentStringConcat' => [
                 '<?php
                     class A {
+                        /** @var non-empty-string */
                         public const STR = "a";
                     }
 
                     class B extends A {
+                        /** @var non-empty-string */
                         public const STR = parent::STR . "b";
                     }
 
                     class C extends B {
+                        /** @var non-empty-string */
                         public const STR = parent::STR . "c";
                     }