git: allow to show git project dir #2507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvimlsp: use vim.diagnostic.get() if available
…test [fix] Fix meaningless tests.
The current way to parse the statusline content and decide whether a
section is empty, has some flaws:
That is for the following reasons:
- accents are considered to be empty (which they really shouldn't)
- manually parsing the expressions using a
`:while ... matchlist() ... endwhile` loop is slow and fragile
- grouping items such as %( %) are not considered
So replace the logic by using `substitute('pat', '\=add()', '')` to
capture all single expression groups into a list and then looping over
those to decide whether the section is empty.
fixes vim-airline#2411
…-condition Test for the correct fern loaded variable.
unicode: Fix check for :UnicodeTable buffer
This extension shows the project dir. It depends on Futivedir, so will only work when the fugitive plugin is available. closes vim-airline#2505
Dujsdujs2
approved these changes
Apr 3, 2022
tpope
reviewed
May 21, 2022
Comment on lines
+12
to
+13
| let dir = FugitiveGitDir(bufnr('')) | ||
| return empty(dir) ? '' : pathshorten(fnamemodify(simplify(dir .. '/../'), ':h:t')) |
There was a problem hiding this comment.
This will return the wrong result for submodules, multiple work trees, bare repositories, and probably other things. Recommended method to retrieve the work tree is FugitiveFind(':/', bufnr('')).
|
ah, thanks for the hing. In general, I am not yet completely satisfied with the pull here, that's why I haven't merged it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension shows the project dir. It depends on Futivedir, so will
only work when the fugitive plugin is available.
closes #2505