Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update typescript and jsdoc, use @import #8723

Merged
merged 1 commit into from
May 15, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented May 7, 2024

  • Updates typescript to @beta, because 5.5.0 supports better syntax for importing types in jsdoc. (In VSCode, use "TypeScript: Select TypeScript version" to use the "workspace version")
  • Updates everything to use that new import.
  • Adds missing type import to spatial-navigation.js — fixes [8.14.0] Type errors #8721
  • Removes a jsdoc plugin that was necessary to support the { import('./file').default} syntax, which jsdoc itself doesn't support.
  • Updates jsdoc
  • Switch to a js config file for jsdoc

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.83%. Comparing base (7b0aede) to head (828b7c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8723      +/-   ##
==========================================
+ Coverage   83.15%   83.83%   +0.68%     
==========================================
  Files         120      120              
  Lines        7995     7995              
  Branches     1924     1924              
==========================================
+ Hits         6648     6703      +55     
+ Misses       1347     1292      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -4703,7 +4706,7 @@ class Player extends Component {
* from the TextTrackList and HtmlTrackElementList
* after a source change
*
* @return { import('./tracks/html-track-element').default }
* @return {HtmlTrackElement}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mister-ben mister-ben merged commit f05769d into videojs:main May 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8.14.0] Type errors
2 participants