Additional cleanup

viamrobotics · Aug 29, 2023 · 75c4d67 · 75c4d67
1 parent 4a7e9a2
commit 75c4d67
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/packages/core/src/lib/select/scroll.ts b/packages/core/src/lib/select/scroll.ts
diff --git a/packages/core/src/lib/select/searchable-select.svelte b/packages/core/src/lib/select/searchable-select.svelte
@@ -6,7 +6,6 @@ import cx from 'classnames';
 import Icon from '$lib/icon/icon.svelte';
 import SelectMenu from './select-menu.svelte';
 import type { SelectState } from './select.svelte';
-import { isOptionInScrollView } from './scroll';
 import {
   type SortOptions,
   getSearchResults,
@@ -109,8 +108,10 @@ const handleNavigate = (direction: number) => {
   }
 
   const element = menu.children[navigationIndex]!;
+  const { top, bottom } = element.getBoundingClientRect();
+  const menuRect = menu.getBoundingClientRect();
 
-  if (!isOptionInScrollView(element)) {
+  if (bottom < menuRect.bottom && top > menuRect.top) {
     element.scrollIntoView({ block: 'nearest' });
   }