Refactor to remove buffer import in types #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be problematic is the `buffer` package is installed. A practical example is that types published in DefinitelyTyped can’t depend on `vfile` or `unified`. Checking the global `Buffer` works fine too.
github-actions
bot
added
👋 phase/new
12 tasks
wooorm
approved these changes
Sep 8, 2022
wooorm
changed the title
This comment has been minimized.
This comment has been minimized.
|
Yes, by removing |
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Sep 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vfile](https://togithub.com/vfile/vfile) | [`^5.3.4` -> `^5.3.5`](https://renovatebot.com/diffs/npm/vfile/5.3.4/5.3.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vfile/vfile</summary> ### [`v5.3.5`](https://togithub.com/vfile/vfile/releases/tag/5.3.5) [Compare Source](https://togithub.com/vfile/vfile/compare/5.3.4...5.3.5) - [`6c5a2f7`](https://togithub.com/vfile/vfile/commit/6c5a2f7) Refactor to remove buffer import in types by [@​remcohaszing](https://togithub.com/remcohaszing) in [vfile/vfile#82 **Full Changelog**: vfile/vfile@5.3.4...5.3.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This can be problematic is the
bufferpackage is installed. A practical example is that types published in DefinitelyTyped can’t depend onvfileorunified.Checking the global
Bufferworks fine too.