Fixes cluster manager is corrupted after merging of hazelcast partition #95
+40
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vietj can you please take a look? Thanks |
vietj
approved these changes
Sep 20, 2018
|
@vietj the build failed on Travis because it reached max length. Can I go ahead and merge? I'll fix the log verbosity issue in master. |
…ast partition The original HZ member uuid is saved as a cluster member attribute. Consequently, even if HZ changes it during partition merging, HAManager and ClusteredEventBus will keep using the same original uuid. Note that when member added event is handled by existing cluster nodes, the member attribute may not be saved yet. In this case, it is safe to use member uuid (at this stage, the member uuid and member attribute are equal).
tsegismont
force-pushed
the
issue/90
branch
from
6d148f8
to
a5c0c68
Compare
|
+1 for the logs |
|
@tsegismont +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
The original HZ member uuid is saved as a cluster member attribute.
Consequently, even if HZ changes it during partition merging, HAManager and ClusteredEventBus will keep using the same original uuid.
Note that when member added event is handled by existing cluster nodes, the member attribute may not be saved yet.
In this case, it is safe to use member uuid (at this stage, the member uuid and member attribute are equal).