Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint #504

Closed
wants to merge 1 commit into from
Closed

Fix lint #504

wants to merge 1 commit into from

Conversation

universeroc
Copy link
Contributor

Use eslint-disable-line to bypass eslint for special case

I check the commit history find the changes is made in 2020, but no one found it breaks down the eslint.

I suggest to make a pre-commit hook to run lint at least.

@ibc
Copy link
Member

ibc commented Jan 21, 2021

Thanks, but the problem is in @typescript-eslint/no-use-before-define and no-undef ESLint rules, not in mediasoup. This did not happen before. On it, but we don't want to ignore tons of lines just to make eslint or @typescript-eslint buggy versions happy.

@ibc ibc closed this Jan 21, 2021
@universeroc
Copy link
Contributor Author

Thanks, but the problem is in @typescript-eslint/no-use-before-define and no-undef ESLint rules, not in mediasoup. This did not happen before. On it, but we don't want to ignore tons of lines just to make eslint or @typescript-eslint buddy versions happy.

Yes, agree with your reply, and current settings not work when running lint, so what's your advice to pass the linters?

Maybe downgrade the eslint version firstly to go through or wait for its patch, we dependent the linter to make sure the coding style.

@ibc
Copy link
Member

ibc commented Jan 22, 2021

Here: #507

@universeroc
Copy link
Contributor Author

Here: #507

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants