Implement NPM web login #4517
Draft
Implement NPM web login #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will check it out this weekend (over week is hard) :) but thanks for taking lead here |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+48
to
+56
| res.send(` | ||
| <form action="/-/v1/login/cli/${req.params.sessionId}" method="post"> | ||
| <label for="username">Username:</label> | ||
| <input type="text" id="username" name="username" required><br><br> | ||
| <label for="password">Password:</label> | ||
| <input type="password" id="password" name="password" required><br><br> | ||
| <input type="submit" value="Login"> | ||
| </form> | ||
| `); |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting High
let me think about this, seems definite doable :) I'll help. Update(03/12/2024): still checking, I might need refactor something first, not sure yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3413
This PR implements NPM login by web (which is the default auth-type if option is not provided).
All the work here is mostly based on this article explaining how NPM login works with web auth : https://marmelab.com/blog/2022/12/22/how-to-implement-web-login-in-a-private-npm-registry.html
This is a work in progress, I need help on :